You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:30:28 UTC
[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #41: fix child spans created on immediate cb from op
tom-pytel opened a new pull request #41:
URL: https://github.com/apache/skywalking-nodejs/pull/41
Two MongoDB fixes here:
* Added flag to indicate whether mongodb is inside an internal call to be able to differentiate when a recursed operation belongs to mongo or the user so that user spans are properly created in case of an immediate callback from mongo but not in case of recursed mongo operations.
* mapReduce will show string functions quoted to differentiate from real passed functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #41: fix child spans created on immediate cb from op
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #41:
URL: https://github.com/apache/skywalking-nodejs/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #41: fix child spans created on immediate cb from op
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #41:
URL: https://github.com/apache/skywalking-nodejs/pull/41#issuecomment-805044795
Something strange is going on with the tests, first the Node 10 test failed but the others succeeded, now Node 10 and 12 successful but Node 14 failed for a strange reason:
```
npm ERR! cb() never called!
npm ERR! This is an error with npm itself. Please report this error at:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #41: fix child spans created on immediate cb from op
Posted by GitBox <gi...@apache.org>.
tom-pytel edited a comment on pull request #41:
URL: https://github.com/apache/skywalking-nodejs/pull/41#issuecomment-805044795
Something strange is going on with the tests, first the Node 10 `TestPlugins` test failed but the others succeeded, now Node 10 and 12 successful but Node 14 `Build` failed for a strange reason:
```
npm ERR! cb() never called!
npm ERR! This is an error with npm itself. Please report this error at:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #41: fix child spans created on immediate cb from op
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #41:
URL: https://github.com/apache/skywalking-nodejs/pull/41#issuecomment-805213107
Looks like it fixed itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org