[GitHub] reminisce commented on a change in pull request #9887: Non-blocking row_sparse_pull

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #9887: Non-blocking row_sparse_pull 
URL: https://github.com/apache/incubator-mxnet/pull/9887#discussion_r172038187
 
 

 ##########
 File path: tests/python/unittest/test_kvstore.py
 ##########
 @@ -76,7 +76,7 @@ def check_row_sparse_pull(kv, count):
         for i in range(count):
             vals.append(mx.nd.zeros(shape).tostype('row_sparse'))
             row_id = np.random.randint(num_rows, size=num_rows)
-            row_ids.append(mx.nd.array(row_id))
+            row_ids.append(mx.nd.array(row_id).reshape((2,2)))
 
 Review comment:
   Why reshape?
   One suggestion: (2, 2) is too hard-coded. If shape is changed in the beginning, the test would fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services