You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by as...@apache.org on 2026/09/13 09:54:16 UTC
(maka) branch fix/transcript-viewport-mounting updated: test(ui): bound continuity traversal and retain failure evidence
This is an automated email from the ASF dual-hosted git repository.
Astro-Han pushed a commit to branch fix/transcript-viewport-mounting
in repository https://gitbox.apache.org/repos/asf/maka.git
The following commit(s) were added to refs/heads/fix/transcript-viewport-mounting by this push:
new ee8a9d3440 test(ui): bound continuity traversal and retain failure evidence
ee8a9d3440 is described below
commit ee8a9d3440ea0d3c361a0dcbb5784dbef98ff72e
Author: AstroHan <le...@outlook.com>
AuthorDate: Sun Sep 13 17:54:10 2026 +0800
test(ui): bound continuity traversal and retain failure evidence
---
.github/workflows/performance-frontend.yml | 13 +++++++++++--
apps/desktop/stories/app-shell.stories.tsx | 6 ++++--
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/performance-frontend.yml b/.github/workflows/performance-frontend.yml
index 81df1bc6b4..32689d7568 100644
--- a/.github/workflows/performance-frontend.yml
+++ b/.github/workflows/performance-frontend.yml
@@ -44,18 +44,27 @@ jobs:
run: |
node --input-type=module <<'JS'
import { chromium } from '@playwright/test';
+ import { mkdir, writeFile } from 'node:fs/promises';
import { startStaticServer, smokeStory } from './scripts/storybook-visual-smoke.mjs';
const server = await startStaticServer('apps/desktop/storybook-static');
const browser = await chromium.launch();
+ const page = await browser.newPage();
+ await mkdir('perf-results', { recursive: true });
try {
- const page = await browser.newPage();
await smokeStory(page, server.baseUrl, {
storyId: 'product-shell-official-appshell--virtual-history-continuity',
colorScheme: 'light', palette: 'default',
});
- } finally { await browser.close(); await server.close(); }
+ } catch (error) {
+ await writeFile('perf-results/continuity-error.txt', String(error));
+ throw error;
+ } finally {
+ await page.screenshot({ path: 'perf-results/continuity.png' });
+ await browser.close(); await server.close();
+ }
JS
- name: Paired viewport mounting on real Host
+ if: ${{ !cancelled() && steps.browsers.outcome == 'success' }}
env:
MAKA_PERF_OUTPUT: ${{ github.workspace }}/perf-results
MAKA_PERF_VARIANTS: A,V,V,A,A,V
diff --git a/apps/desktop/stories/app-shell.stories.tsx b/apps/desktop/stories/app-shell.stories.tsx
index 98ea5938fb..9e9b650a29 100644
--- a/apps/desktop/stories/app-shell.stories.tsx
+++ b/apps/desktop/stories/app-shell.stories.tsx
@@ -2591,7 +2591,7 @@ export const VirtualHistoryContinuity: Story = {
const traverse = async (direction: -1 | 1) => {
for (let step = 0; step < 160; step++) {
- scrollAsReader(root, root.scrollTop + direction * root.clientHeight / 2);
+ scrollAsReader(root, root.scrollTop + direction * root.clientHeight);
await painted(5);
if (direction < 0 ? root.scrollTop <= 1 : root.scrollHeight - root.clientHeight - root.scrollTop <= 1) return;
}
@@ -2615,7 +2615,9 @@ export const VirtualHistoryContinuity: Story = {
selection.addRange(range);
const text = selection.toString();
expect(text.length).toBeGreaterThan(0);
- await traverse(-1);
+ scrollAsReader(root, 0);
+ await waitFor(() => expect(root.scrollTop).toBeLessThan(knownHeight / 2));
+ await painted(8);
expect(selected.isConnected, 'an active selection must survive leaving the viewport').toBe(true);
expect(selection.toString()).toBe(text);
selection.removeAllRanges();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org