You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/26 06:39:16 UTC
Review Request 42783: Fixed error message style in 'roles::validate'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42783/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846
Diff: https://reviews.apache.org/r/42783/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42783: Fixed error message style in
'roles::validate'.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42783/#review116276
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Jan. 26, 2016, 5:39 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42783/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 5:39 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846
>
> Diff: https://reviews.apache.org/r/42783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42783: Fixed error message style in
'roles::validate'.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42783/#review116280
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 一月 26, 2016, 5:39 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42783/
> -----------------------------------------------------------
>
> (Updated 一月 26, 2016, 5:39 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846
>
> Diff: https://reviews.apache.org/r/42783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42783: Fixed error message style in
'roles::validate'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42783/#review116284
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42761, 42762, 42783]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 26, 2016, 5:39 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42783/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 5:39 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846
>
> Diff: https://reviews.apache.org/r/42783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>