You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Ruben Q L (Jira)" <ji...@apache.org> on 2020/11/20 17:31:00 UTC

[jira] [Created] (CALCITE-4415) SqlStdOperatorTable.NOT_LIKE has a wrong implementor

Ruben Q L created CALCITE-4415:
----------------------------------

             Summary: SqlStdOperatorTable.NOT_LIKE has a wrong implementor
                 Key: CALCITE-4415
                 URL: https://issues.apache.org/jira/browse/CALCITE-4415
             Project: Calcite
          Issue Type: Bug
            Reporter: Ruben Q L
             Fix For: 1.27.0


{{SqlStdOperatorTable.NOT_LIKE}}'s implementor defined in {{RexImpTable}} is currently the same as {{LIKE}} (i.e. NOT_LIKE does the same as LIKE):
{code}
map.put(LIKE, likeImplementor);
map.put(NOT_LIKE, likeImplementor);
{code}

It should be:
{code}
map.put(LIKE, likeImplementor);
map.put(NOT_LIKE, NotImplementor.of(likeImplementor));
{code}

Luckily, SQL queries seem to not suffer the consequences because {{StandardConvertletTable}} expands {{x NOT LIKE y}} into {{NOT (x LIKE y)}}, so the issue is avoided:
{code}
    // Expand "x NOT LIKE y" into "NOT (x LIKE y)"
    registerOp(SqlStdOperatorTable.NOT_LIKE,
        (cx, call) -> cx.convertExpression(
            SqlStdOperatorTable.NOT.createCall(SqlParserPos.ZERO,
                SqlStdOperatorTable.LIKE.createCall(SqlParserPos.ZERO,
                    call.getOperandList()))));
{code}

However, creating a plan via RelBuilder using {{SqlStdOperatorTable.NOT_LIKE}} will lead to incorrect results.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)