You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org> on 2009/11/13 03:32:39 UTC
[jira] Resolved: (TRINIDAD-1636) Code Cleanup: Remove 'source' in
the FileSystemStyleCache constructor and all related code.
[ https://issues.apache.org/jira/browse/TRINIDAD-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman resolved TRINIDAD-1636.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.13-core
> Code Cleanup: Remove 'source' in the FileSystemStyleCache constructor and all related code.
> -------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1636
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1636
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Affects Versions: 1.2.12-core
> Reporter: Jeanne Waldman
> Assignee: Jeanne Waldman
> Fix For: 1.2.13-core
>
>
> This is a sub-issue to TRINIDAD-1460 implement FileSystemStyleCache code review comments
> I noticed that the 'source' in the constructor is always null since it is only called from SkinStyleProvider, and so the code around _resolver, _sourceFile, etc. should just be deleted since this 'feature' is never used and it makes the code extra confusing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.