You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/21 20:31:18 UTC

[GitHub] [kafka] C0urante commented on a change in pull request #8118: KAFKA-9472: Remove deleted tasks from status store

C0urante commented on a change in pull request #8118:
URL: https://github.com/apache/kafka/pull/8118#discussion_r428897363



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TaskStatus.java
##########
@@ -61,5 +61,16 @@ public TaskStatus(ConnectorTaskId id, State state, String workerUrl, int generat
          */
         void onShutdown(ConnectorTaskId id);
 
+        /**
+         * Invoked after the task is no longer needed. This differs from
+         * {@link #onShutdown(ConnectorTaskId)} in that a shut down task may be expected to restart
+         * soon (as in the case of a rebalance), whereas a destroyed task will not be restarted
+         * until and unless a reconfiguration of its connector occurs.
+         * 
+         * This may occur after the number of tasks for a connector is reduced.

Review comment:
       Ack, addressed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org