You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2013/10/10 10:05:13 UTC

svn commit: r1530869 - in /httpcomponents/httpcore/trunk: RELEASE_NOTES.txt httpcore/src/main/java/org/apache/http/impl/pool/BasicConnFactory.java

Author: olegk
Date: Thu Oct 10 08:05:12 2013
New Revision: 1530869

URL: http://svn.apache.org/r1530869
Log:
HTTPCORE-354: BasicConnFactory don't use SocketConfig#isSoKeepAlive
Contributed by David Ignjic <ignjic at gmail.com>

Modified:
    httpcomponents/httpcore/trunk/RELEASE_NOTES.txt
    httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/pool/BasicConnFactory.java

Modified: httpcomponents/httpcore/trunk/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/RELEASE_NOTES.txt?rev=1530869&r1=1530868&r2=1530869&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpcore/trunk/RELEASE_NOTES.txt Thu Oct 10 08:05:12 2013
@@ -1,6 +1,9 @@
 Changes since 4.3
 -------------------
 
+* [HTTPCORE-354] BasicConnFactory don't use SocketConfig#isSoKeepAlive.
+  Contributed by David Ignjic <ignjic at gmail.com>
+
 * [HTTPCORE-347] (Regression) HttpResponse#setStatusCode() does not update reason phrase.
   Contributed by Oleg Kalnichevski <olegk at apache.org>
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/pool/BasicConnFactory.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/pool/BasicConnFactory.java?rev=1530869&r1=1530868&r2=1530869&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/pool/BasicConnFactory.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/pool/BasicConnFactory.java Thu Oct 10 08:05:12 2013
@@ -170,6 +170,7 @@ public class BasicConnFactory implements
         if (linger >= 0) {
             socket.setSoLinger(linger > 0, linger);
         }
+        socket.setKeepAlive(this.sconfig.isSoKeepAlive());
         return this.connFactory.createConnection(socket);
     }