[GitHub] chetanmeh opened a new pull request #3983: Support storing attachment in a sub folder in S3 bucket

[GitBox <gi...@apache.org>]

chetanmeh opened a new pull request #3983: Support storing attachment in a sub folder in S3 bucket
URL: https://github.com/apache/incubator-openwhisk/pull/3983
 
 
   Enable configuring a common parent folder under which all attachments stored. This enables sharing same bucket with multiple clusters
   
   ## Description
   
   Currently the attachments are stored with path structure `whiskentity/<namespace>/<docId>/<name>`. With this PR it would be possible to also specify a parent path under which this path would be created. So path structure would be like `<prefix>/whiskentity/<namespace>/<docId>/<name>`
   
   ### Config
   
   The prefix can be specified via `prefix` setting (optional)
   
   ```
   whisk {
        s3 {
         alpakka {
            aws {
              credentials {
                provider = static
                access-key-id = "$accessKey"
                secret-access-key = "$secretAccessKey"
              }
              region {
                provider = static
                default-region = us-west-2
              }
            }
            endpoint-url = "http://localhost:$port"
         }
         bucket = "openwhisk"
         prefix = "dev-cluster"
        }
   }
   ```
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [x] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services