[GitHub] [hadoop] xinglin commented on a diff in pull request #5764: HDFS-17055 Export HAState as a metric from Namenode for monitoring

["xinglin (via GitHub)" <gi...@apache.org>]

xinglin commented on code in PR #5764:
URL: https://github.com/apache/hadoop/pull/5764#discussion_r1239137137


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -2051,6 +2056,26 @@ synchronized HAServiceState getServiceState() {
     return state.getServiceState();
   }
 
+  /**
+   * Emit Namenode HA service state as an integer so that one can monitor NN HA
+   * state based on this metric.
+   *
+   * @return  0 when not fully started
+   *          1 for active or standalone (non-HA) NN
+   *          2 for standby
+   *          3 for observer
+   *

Review Comment:
   Searching codebase, it seems we would set a state to STOPPING state only in YARN ResourceManager HA. We are not using that state in HDFS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org