You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/05/21 19:39:00 UTC

[jira] [Commented] (TINKERPOP-2562) Remove GraphSON 2 option in TraversalOpProcessor

    [ https://issues.apache.org/jira/browse/TINKERPOP-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349454#comment-17349454 ] 

ASF GitHub Bot commented on TINKERPOP-2562:
-------------------------------------------

spmallette opened a new pull request #1423:
URL: https://github.com/apache/tinkerpop/pull/1423


   https://issues.apache.org/jira/browse/TINKERPOP-2562
   
   This was retained to support much older drivers. No driver sends Bytecode this way anymore so it should be safe to remove. It probably should have been done in 3.5.0, but was missed. The UnifiedHandler never supported this message form.
   
   Builds with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove GraphSON 2 option in TraversalOpProcessor
> ------------------------------------------------
>
>                 Key: TINKERPOP-2562
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2562
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.11
>            Reporter: Stephen Mallette
>            Priority: Major
>              Labels: breaking
>
> There is an option for the {{TraversalOpProcessor}} to take a GraphSON 2 string rather than a {{Bytecode}} object. Perhaps that is the way it is for legacy reasons - not sure, but being bound to GraphSON 2 seems odd. Need to investigate further, but I would think that we just want to expect a {{Bytecode}} object and that's it:
> https://github.com/apache/tinkerpop/blob/3.4.11/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L82



--
This message was sent by Atlassian Jira
(v8.3.4#803005)