You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/12 18:58:13 UTC

[GitHub] [incubator-pinot] npawar edited a comment on pull request #5438: Add additional datetime functionality

npawar edited a comment on pull request #5438:
URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-673033710


   > @reallocf Can we keep java function names in camelCase and use @ScalarFunction annotation's name parameter to provide names to be used in queries?
   > Otherwise LGTM! Some tests are failing though. Please take a look at them.
   
   Fixed both. Tests are also passing now @KKcorps 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org