[GitHub] [kafka] dajac commented on a change in pull request #10954: WIP KIP-709: Implement batching for fetchOffsets

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#discussion_r662850732



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##########
@@ -888,22 +888,26 @@ default ListConsumerGroupsResult listConsumerGroups() {
     }
 
     /**
-     * List the consumer group offsets available in the cluster.
-     *
+     * List the consumer group offsets available in the cluster for the given list of consumer
+     * groups.
+     * @param groupIds List of consumer group ids to list offsets for.
      * @param options The options to use when listing the consumer group offsets.
      * @return The ListGroupOffsetsResult
      */
-    ListConsumerGroupOffsetsResult listConsumerGroupOffsets(String groupId, ListConsumerGroupOffsetsOptions options);
+    ListConsumerGroupOffsetsResult listConsumerGroupOffsets(List<String> groupIds, ListConsumerGroupOffsetsOptions options);

Review comment:
       Don't we need to keep the existing methods for backward compatibility? We could perhaps deprecate them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org