You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 18:33:08 UTC

[GitHub] [airflow] kaxil commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

kaxil commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-829493407


   @DerekHeldtWerle Can you fix the failing static checks please: https://github.com/apache/airflow/pull/15238/checks?check_run_id=2301349726#step:10:245
   
   ```diff
   diff --git a/chart/tests/test_configmap.py b/chart/tests/test_configmap.py
   index a58f72a..6a9e286 100644
   --- a/chart/tests/test_configmap.py
   +++ b/chart/tests/test_configmap.py
   @@ -26,9 +26,7 @@ class ConfigmapTest(unittest.TestCase):
        def test_single_annotation(self):
            docs = render_chart(
                values={
   -                "airflowConfigAnnotations": {
   -                    "key": "value"
   -                },
   +                "airflowConfigAnnotations": {"key": "value"},
                },
                show_only=["templates/configmaps/configmap.yaml"],
            )
   @@ -39,10 +37,7 @@ class ConfigmapTest(unittest.TestCase):
        def test_multiple_annotations(self):
            docs = render_chart(
                values={
   -                "airflowConfigAnnotations": {
   -                    "key": "value",
   -                    "key-two": "value-two"
   -                },
   +                "airflowConfigAnnotations": {"key": "value", "key-two": "value-two"},
                },
                show_only=["templates/configmaps/configmap.yaml"],
            )
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org