You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by Andrew Stitcher <as...@apache.org> on 2012/09/06 00:41:43 UTC

Review Request: C++ wrappers for proton pn_message_t and pn_messenger_t

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6929/
-----------------------------------------------------------

Review request for qpid, Gordon Sim, Cliff Jansen, and Rafael Schloming.


Description
-------

As an experiment I've wrapped the pn_message_t and Pn_messenger_t structs and operations in very lightweight c++ classes pn::Message and pn::Messenger.

To see how this looks I've also transcribed the python messenger examples to these new C++ wrappers.

If this is generally liked then I propose to wrap the rest of the proton API similarly.

Some possible controversial (and definitely revisable) decisions I made here:

* I don't like to prefix setters and getters with "set" and "get" so I didn't

* I put the wrappers in the supplied header files rather than in a new header file.


Diffs
-----

  /proton/trunk/examples/c++/client.cpp PRE-CREATION 
  /proton/trunk/examples/c++/recv.cpp PRE-CREATION 
  /proton/trunk/examples/c++/send.cpp PRE-CREATION 
  /proton/trunk/examples/c++/server.cpp PRE-CREATION 
  /proton/trunk/proton-c/include/proton/message.h 1381265 
  /proton/trunk/proton-c/include/proton/messenger.h 1381265 

Diff: https://reviews.apache.org/r/6929/diff/


Testing
-------

Compiled and ran the transcribed c++ examples


Thanks,

Andrew Stitcher