You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xmlrpc-dev@ws.apache.org by Martin Poeschl <mp...@marmot.at> on 2002/03/08 02:12:45 UTC
[patch] Re: cvs commit: xml-rpc/src/java/org/apache/xmlrpc/applet
SimpleXmlRpcClient.java
why not add a write(byte[]) method??
Index: ./src/java/org/apache/xmlrpc/applet/SimpleXmlRpcClient.java
===================================================================
RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/applet/SimpleXmlRpcClient.java,v
retrieving revision 1.2
diff -r1.2 SimpleXmlRpcClient.java
191,192c191
< // FIXME: Find a better way than creating a new String and converting to a char[]
< writer.write (new String(Base64.encode((byte[])what)).toCharArray());
---
> writer.write (Base64.encode((byte[])what));
628a628,632
> }
>
> public void write (byte[] text)
> {
> buf.append (text);
Re: [patch] Re: cvs commit: xml-rpc/src/java/org/apache/xmlrpc/applet SimpleXmlRpcClient.java
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Done, thanks Martin.
Martin Poeschl <mp...@marmot.at> writes:
> why not add a write(byte[]) method??
>
>
> Index: ./src/java/org/apache/xmlrpc/applet/SimpleXmlRpcClient.java
> ===================================================================
> RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/applet/SimpleXmlRpcClient.java,v
> retrieving revision 1.2
> diff -r1.2 SimpleXmlRpcClient.java
> 191,192c191
> < // FIXME: Find a better way than creating a new String and converting to a char[]
> < writer.write (new String(Base64.encode((byte[])what)).toCharArray());
> ---
> > writer.write (Base64.encode((byte[])what));
> 628a628,632
> > }
> >
> > public void write (byte[] text)
> > {
> > buf.append (text);
Re: [patch] Re: cvs commit: xml-rpc/src/java/org/apache/xmlrpc/applet SimpleXmlRpcClient.java
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Done, thanks Martin.
Martin Poeschl <mp...@marmot.at> writes:
> why not add a write(byte[]) method??
>
>
> Index: ./src/java/org/apache/xmlrpc/applet/SimpleXmlRpcClient.java
> ===================================================================
> RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/applet/SimpleXmlRpcClient.java,v
> retrieving revision 1.2
> diff -r1.2 SimpleXmlRpcClient.java
> 191,192c191
> < // FIXME: Find a better way than creating a new String and converting to a char[]
> < writer.write (new String(Base64.encode((byte[])what)).toCharArray());
> ---
> > writer.write (Base64.encode((byte[])what));
> 628a628,632
> > }
> >
> > public void write (byte[] text)
> > {
> > buf.append (text);