You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Giovds (via GitHub)" <gi...@apache.org> on 2024/11/22 14:14:53 UTC
[PR] [MCHANGES-431] Replace GitHub client with recommended client from docs [maven-changes-plugin]
Giovds opened a new pull request, #51:
URL: https://github.com/apache/maven-changes-plugin/pull/51
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHANGES-431) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MCHANGES-XXX] SUMMARY`,
where you replace `MCHANGES-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [x] Also format the first line of the commit message like `[MCHANGES-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-431] Replace GitHub client with recommended client from docs [maven-changes-plugin]
Posted by "Giovds (via GitHub)" <gi...@apache.org>.
Giovds commented on PR #51:
URL: https://github.com/apache/maven-changes-plugin/pull/51#issuecomment-2493868123
Not sure if we want to manually make API calls or if we want to use the provided dependency as described in the docs. Alternatively we can wait for official support, but doesn't seem soon: https://github.com/orgs/octokit/discussions/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-431] Replace GitHub client with recommended client from docs [maven-changes-plugin]
Posted by "Giovds (via GitHub)" <gi...@apache.org>.
Giovds commented on PR #51:
URL: https://github.com/apache/maven-changes-plugin/pull/51#issuecomment-2493864461
Would still need to test this on a existing project. `mvn clean verify` and `mvn clean verify -Prun-its` report green builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-431] Replace GitHub client with recommended client from docs [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #51:
URL: https://github.com/apache/maven-changes-plugin/pull/51#issuecomment-2493994561
> Not sure if we want to manually make API calls or if we want to use the provided dependency as described in the docs. Alternatively we can wait for official support, but doesn't seem soon: https://github.com/orgs/octokit/discussions/71
Now unit test is ok ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-431] Replace GitHub client with recommended client from docs [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #51:
URL: https://github.com/apache/maven-changes-plugin/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org