You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/14 10:00:23 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

feluelle commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303236433
 
 

 ##########
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##########
 @@ -36,7 +36,7 @@ def stab(tab=1):
     return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   > Should we maintain code in `_vendor`?
   
   If you ask me, I would not do it, simply because we have no tests covering our changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services