You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/15 12:42:33 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4693: server: fix finding pools for volume migration
shwstppr opened a new pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693
### Description
TBA
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-780538633
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779438268
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779451354
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779200755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784098068
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784994417
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-785462389
<b>Trillian test result (tid-3614)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43017 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4693-t3614-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 785.15 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779222102
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2709
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-780059303
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#discussion_r581917556
##########
File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StoragePoolAllocator.java
##########
@@ -45,10 +51,12 @@
* @param ExcludeList
* avoid
* @param int returnUpTo (use -1 to return all possible pools)
+ * @param boolean bypassStorageTypeCheck
Review comment:
why add javadoc without description? please add a short sentence on how to use it, or remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-781331368
<b>Trillian test result (tid-3567)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31544 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4693-t3567-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 235.79 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-780538023
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779200755
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#discussion_r581951855
##########
File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StoragePoolAllocator.java
##########
@@ -45,10 +51,12 @@
* @param ExcludeList
* avoid
* @param int returnUpTo (use -1 to return all possible pools)
+ * @param boolean bypassStorageTypeCheck
Review comment:
@DaanHoogland done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784205494
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784309849
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784995206
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-781030019
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784205494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-780059303
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784241441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-781030260
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779201337
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779438480
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784098068
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-780560254
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779201337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784224498
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784241441
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784191845
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784752912
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4693:
URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-779776039
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org