[GitHub] [flink] Thesharing commented on pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

[GitBox <gi...@apache.org>]

Thesharing commented on pull request #17777:
URL: https://github.com/apache/flink/pull/17777#issuecomment-1009779106


   > hi @Thesharing @tillrohrmann sorry for late response. if we do not want to make changes such as docs and many file, we can change code from MINUTES(ChronoUnit.MINUTES, singular("min"), plural("minute")), to this MINUTES(ChronoUnit.MINUTES, singular("min"), singular("m"), plural("minute")), wil you receive it or just simple modify the comments from 10 m to 10 min
   > 
   > rest.flamegraph.cleanup-interval after which cached stats are cleaned up if not accessed. It can" + " be specified using notation: "100 s", "10 m"."
   
   This makes me a bit confused. I get that the core change of this improvement is `MINUTES(ChronoUnit.MINUTES, singular("m"), singular("min"), plural("minute"))`. I'm wondering what test cases is not passed after the change and why they are broken. Would you please list all the test cases that are not passed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org