You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/29 18:27:34 UTC

[GitHub] larroy commented on a change in pull request #8701: add inline for cached op & fixed a bug when calling backward on variable

larroy commented on a change in pull request #8701: add inline for cached op & fixed a bug when calling backward on variable
URL: https://github.com/apache/incubator-mxnet/pull/8701#discussion_r153874268
 
 

 ##########
 File path: src/c_api/c_api_ndarray.cc
 ##########
 @@ -157,7 +157,25 @@ int MXCreateCachedOp(SymbolHandle handle,
 
   API_BEGIN();
   *out = new std::shared_ptr<Imperative::CachedOp>(
-      new Imperative::CachedOp(*sym));
+      new Imperative::CachedOp(
+        *sym, std::vector<std::pair<std::string, std::string> >()));
 
 Review comment:
   why don't we have a typedef for this one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services