[GitHub] [orc] coderex2522 commented on a diff in pull request #1158: ORC-961: [C++] expose related metrics of the reader

[GitBox <gi...@apache.org>]

coderex2522 commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r911682751


##########
c++/include/orc/Reader.hh:
##########
@@ -32,13 +32,40 @@
 #include <set>
 #include <string>
 #include <vector>
+#include <atomic>
 
 namespace orc {
 
   // classes that hold data members so we can maintain binary compatibility
   struct ReaderOptionsPrivate;
   struct RowReaderOptionsPrivate;
 
+  /**
+   * Expose the reader metrics including the latency and
+   * number of calls of the decompression/decoding/IO modules.
+   */
+  struct ReaderMetrics {
+    std::atomic<uint64_t> ReaderCount{0};
+    // ReaderInclusiveLatencyUs contains the latency of
+    // the decompression/decoding/IO modules.
+    std::atomic<uint64_t> ReaderInclusiveLatencyUs{0};
+    std::atomic<uint64_t> DecompCount{0};

Review Comment:
   The DecompCount and DecompLatencyUs have been replaced with DecompressionCall and DecompressionLatencyUs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org