You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Patrick Wendell (JIRA)" <ji...@apache.org> on 2014/11/13 06:42:33 UTC
[jira] [Comment Edited] (SPARK-4375) Assembly built with Maven is
missing most of repl classes
[ https://issues.apache.org/jira/browse/SPARK-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209305#comment-14209305 ]
Patrick Wendell edited comment on SPARK-4375 at 11/13/14 5:37 AM:
------------------------------------------------------------------
Hey Sandy,
What about the following solution:
1. For the repl case, we make the change you are suggesting and simply drop the need for -Pscala-2.10 to be there explicilty.
2. We no longer include the examples module or the external project modules by default in the build. There is a profile for each of the external projects and a profile for the examples.
2. When building the examples, you need to specify, somewhat pedantically, all of the necessary external sub projects and also -Pscala-2.10 or -Pscala-2.11. We can just give people the exact commands to run for 2.10 and 2.11 examples in the maven docs.
The main benefits I see is that there is no regression for someone doing a package for Scala 2.10 which is the common case. If someone wants to build the examples, they need to go and do a bit of extra work to look up the new command, but it's mostly straightforward. Of course, all of our packages will still have the examples pre-built.
was (Author: pwendell):
Hey Sandy,
What about the following solution:
1. For the repl case, we make the change you are suggesting and simply drop the need for -Pscala-2.10 to be there explicilty.
2. We no longer include the examples module or the external project modules by default in the build.
2. When building the examples, you need to specify, somewhat pedantically, all of the necessary external sub projects and also -Pscala-2.10 or -Pscala-2.11. We can just give people the exact commands to run for 2.10 and 2.11 examples in the maven docs.
The main benefits I see is that there is no regression for someone doing a package for Scala 2.10 which is the common case. If someone wants to build the examples, they need to go and do a bit of extra work to look up the new command, but it's mostly straightforward. Of course, all of our packages will still have the examples pre-built.
> Assembly built with Maven is missing most of repl classes
> ---------------------------------------------------------
>
> Key: SPARK-4375
> URL: https://issues.apache.org/jira/browse/SPARK-4375
> Project: Spark
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Sandy Ryza
> Priority: Blocker
>
> In particular, the ones in the split scala-2.10/scala-2.11 directories aren't being added
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org