You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/08 00:41:54 UTC

[GitHub] [incubator-pinot] xiangfu0 commented on pull request #6889: fix integration tests for kafka ports

xiangfu0 commented on pull request #6889:
URL: https://github.com/apache/incubator-pinot/pull/6889#issuecomment-834907244


   > I don't fully understand the intention of this PR. Do we want to pick the port from a random kafka server, or kafka might change the passed-in port if it is unavailable?
   > Please update the PR description and commit message
   
   The Kafka port might change, but we always use default port.
   
   Kafka broker close is async, so it's possible that the next test connects to the previous un closed kafka.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org