You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2019/12/28 00:48:16 UTC

[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #13: sama3 sam_serial.c USART selection fixes

adamfeuer opened a new pull request #13: sama3 sam_serial.c USART selection fixes
URL: https://github.com/apache/incubator-nuttx/pull/13
 
 
   ### Summary
   
   * Fixes bugs in USART console selection
   * Fixes a few typos in the SAMA5D27 README file
   
   ### Impact
   
   * SAMA5 USART console selection should work correctly now
   
   ### Limitations / TODO
   
   * SAMA5D27 console input still not working due to incomplete port – hopefully more changes will come in a future PR
   
   ### Detail
   
   * Looks like these were typos when the port was created
   
   ### Testing
   
   * Manual – compile and run on a SAMA5D27-XULT board by loading using a Segger J-Link debugger
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #13: sama3 sam_serial.c USART selection fixes

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #13: sama3 sam_serial.c USART selection fixes
URL: https://github.com/apache/incubator-nuttx/pull/13
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #13: sama3 sam_serial.c USART selection fixes

Posted by GitBox <gi...@apache.org>.
adamfeuer commented on issue #13: sama3 sam_serial.c USART selection fixes
URL: https://github.com/apache/incubator-nuttx/pull/13#issuecomment-569866163
 
 
   @patacongo Is there anything else fix in this PR before it can be merged?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #13: sama3 sam_serial.c USART selection fixes

Posted by GitBox <gi...@apache.org>.
adamfeuer commented on issue #13: sama3 sam_serial.c USART selection fixes
URL: https://github.com/apache/incubator-nuttx/pull/13#issuecomment-569377932
 
 
   @patacongo I moved the pin disambiguation to `board.h`, thanks for pointing this out.
   
   Anything else to improve or correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services