You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Amit Jain (JIRA)" <ji...@apache.org> on 2017/07/07 05:26:00 UTC
[jira] [Commented] (OAK-6413) FileCache getIfPresent doesn't update
cache hit/miss counters
[ https://issues.apache.org/jira/browse/OAK-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077612#comment-16077612 ]
Amit Jain commented on OAK-6413:
--------------------------------
Thanks [~ioancris]
Fixed in trunk with r1801118 & r1801119
> FileCache getIfPresent doesn't update cache hit/miss counters
> -------------------------------------------------------------
>
> Key: OAK-6413
> URL: https://issues.apache.org/jira/browse/OAK-6413
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: blob
> Affects Versions: 1.6.1
> Reporter: Ioan-Cristian Linte
> Assignee: Amit Jain
> Priority: Minor
>
> {{FileCache.getIfPresent}} bypasses cache access if key is not in cache and CacheStats for "DataStore-DownloadCache" MBean will always have 100% hit rate even when Blobs will be downloaded from the BlobStore backend by {{AbstractSharedCachingDataStore}} because of the miss in the cache.
> I suggest the following change:
> {{FileCache.getIfPresent}} to call {{CacheLIRS.getIfPresent}} which will update the cache stats (miss and hit counters).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)