mod_ftp - funky install target...

[Niklas Edmundsson <ni...@acc.umu.se>]

Getting annoyed with the make install target of mod_ftp always adding 
an extra LoadModule directive for it despite I already have one 
inside <IfDefine FTP> I had a quick peek at it.

It seems that it tries to do something smart, but fails miserably. 
Most notably, it's mucking around with commented entries in the config 
file, so:

# LoadModule ftp_module ...
becomes this on make install:
#LoadModule ftp_module ...
and doing make install again it becomes:
LoadModule ftp_module ...

Not that nice, really.

Also, I think it's a bad habit editing commented entries, at least I 
don't expect those to be touched. It's much more sane to add a new 
entry with current values if they have changed.

I'd suggest that the make install target ONLY adds example config if 
it doesn't find a trace of LoadModule ftp_module in the file, 
commented or not. This will have the effect of those that's done 
clever things in their config will be spared of the example drivel as 
long as they have LoadModule ftp_module in the file somewhere.

Thoughts?


/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Commander? There's a problem...
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=