[GitHub] [incubator-paimon] TyrantLucifer commented on pull request #658: [spark] Extract SparkInputPartitionReader from paimon spark connector

["TyrantLucifer (via GitHub)" <gi...@apache.org>]

TyrantLucifer commented on PR #658:
URL: https://github.com/apache/incubator-paimon/pull/658#issuecomment-1477200654

   > Hi @TyrantLucifer , thanks for your contribution, can you explain the disadvantages of anonymous internal classes?
   
   Thank you for your reply. There are two benefits to converting an internal anonymous class to a regular entity class:
   
   1. Improved code readability and maintainability: Using an explicit entity class with a well-defined name and a clear purpose makes it easier for other developers to understand the code's purpose and functionality. This can also make it easier to maintain the code over time.
   
   2. Enhanced code reusability: By separating the anonymous class into a separate entity class, the class can be reused in other parts of the codebase, potentially reducing code duplication and improving overall code quality.
   
   Of course, from a performance perspective, there is no difference between the two approaches.
   
   What do you think about it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org