You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/25 22:34:31 UTC
[GitHub] [couchdb] jjrodrig opened a new pull request #2724: Improve
cookie_auth_test.exs initialization
jjrodrig opened a new pull request #2724: Improve cookie_auth_test.exs initialization
URL: https://github.com/apache/couchdb/pull/2724
## Overview
Some times jenkins is failling during cookie_auth_test.exs initialization.
```
[2020-03-22T16:10:58.479Z] CookieAuthTest
[2020-03-22T16:11:04.587Z] * test cookie auth
* test cookie auth (5022.9ms)
[2020-03-22T16:11:04.587Z]
[2020-03-22T16:11:04.587Z] 1) test cookie auth (CookieAuthTest)
[2020-03-22T16:11:04.588Z] test/elixir/test/cookie_auth_test.exs:206
[2020-03-22T16:11:04.588Z] Assertion with == failed
[2020-03-22T16:11:04.588Z] code: assert resp.status_code() == expect_response
[2020-03-22T16:11:04.588Z] left: 404
[2020-03-22T16:11:04.588Z] right: 200
[2020-03-22T16:11:04.588Z] stacktrace:
[2020-03-22T16:11:04.588Z] test/elixir/test/cookie_auth_test.exs:107: CookieAuthTest.open_as/3
[2020-03-22T16:11:04.588Z] test/elixir/test/cookie_auth_test.exs:208: (test)
```
The problem arises in the following line that respond after longpoll timeout without the expected response.
```
resp =
Couch.get(
"/#{@users_db}/_changes",
query: [feed: "longpoll", timeout: 5000, filter: "_design"]
)
[notice] 2020-03-22T16:11:03.403004Z node1@127.0.0.1 <0.4111.1> f5456adb0c 127.0.0.1:15984 127.0.0.1 adm GET /_users/_changes?feed=longpoll&timeout=5000&filter=_design 200 ok 5002
```
This PR adds a retry during this initialization giving more chances to success.
## Testing recommendations
```
make elixir
```
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
N/A
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] jjrodrig merged pull request #2724: Improve
cookie_auth_test.exs initialization
Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #2724: Improve cookie_auth_test.exs initialization
URL: https://github.com/apache/couchdb/pull/2724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services