You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Andor Molnar (JIRA)" <ji...@apache.org> on 2018/04/27 14:32:00 UTC

[jira] [Created] (ZOOKEEPER-3027) Accidently removed public API of FileTxnLog.setPreallocSize()

Andor Molnar created ZOOKEEPER-3027:
---------------------------------------

             Summary: Accidently removed public API of FileTxnLog.setPreallocSize()
                 Key: ZOOKEEPER-3027
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3027
             Project: ZooKeeper
          Issue Type: Bug
          Components: server
    Affects Versions: 3.5.4, 3.6.0, 3.4.13
            Reporter: Andor Molnar
            Assignee: Andor Molnar
             Fix For: 3.5.4, 3.6.0, 3.4.13


In my latest commit regarding TxnLogToolkit there's a refactor to outsource file padding logic from FileTxnLog to a separate class:

[https://github.com/apache/zookeeper/commit/126fb0f22d701cad58bf3123bf7d8f2219e60387#diff-89717124564925d61d29dd817bcdd915]

Unfortunately public static method setPreallocSize(int) has also been moved to the new class, but it's being actively used by hadoop-common project too:

[https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/ClientBaseWithFixes.java#L384]

I'd like to submit a patch to revert the deleted method which is going to call the new one, but will keep backward compatibility with Hadoop.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)