You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by jaredjstewart <gi...@git.apache.org> on 2017/08/01 01:08:31 UTC

[GitHub] geode issue #664: Fix for GEODE-3292

Github user jaredjstewart commented on the issue:

    https://github.com/apache/geode/pull/664
  
    Hi Juan,
    
    Thanks for your contribution!  Your changes look good to me, but our [Criteria for Code Submissions](https://cwiki.apache.org/confluence/display/GEODE/Criteria+for+Code+Submissions) require having tests for the behavior that is being changed.  In this case, it would be good to add a test to make sure that GEODE-3292 has been fixed and will not reoccur.  Typically I would point you towards an existing test to use as a guide, but since your changes appear to be in an area of the code that is not particularly well-tested, let me know if you don't feel confident in writing such a test and I can help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---