You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/19 02:43:47 UTC

[GitHub] [nuttx] dnschwa opened a new pull request, #8185: Acknowledge interrupt before installing callback

dnschwa opened a new pull request, #8185:
URL: https://github.com/apache/nuttx/pull/8185

   ## Summary
   Acknowledge the interrupt before installing the callback...
   
   ## Impact
   ...otherwise it will fire unexpectedly if it's already pending.
   
   ## Testing
   Impact no longer observed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] dnschwa closed pull request #8185: Acknowledge interrupt before installing callback

Posted by GitBox <gi...@apache.org>.
dnschwa closed pull request #8185: Acknowledge interrupt before installing callback
URL: https://github.com/apache/nuttx/pull/8185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] dnschwa commented on pull request #8185: Acknowledge interrupt before installing callback

Posted by GitBox <gi...@apache.org>.
dnschwa commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396798001

   Didn't realize this is breaking existing code. Thanks, I will look at your example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] dnschwa commented on pull request #8185: Acknowledge interrupt before installing callback

Posted by GitBox <gi...@apache.org>.
dnschwa commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396772931

   Didn't realize this is breaking existing code. Thanks, I will look at your example.
   However, might `up_disable_irq(irq);` not work istead? (since it is not affecting HW state)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] dnschwa commented on pull request #8185: Acknowledge interrupt before installing callback

Posted by GitBox <gi...@apache.org>.
dnschwa commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396627509

   Does it make sense for the callback to service an event that happened *before* it the callback was installed?
   This is not theoretical either, I've encountered this in a real-world case. What is the suggested workaround to avoid this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] davids5 commented on pull request #8185: Acknowledge interrupt before installing callback

Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396733765

   It is service and device dependent. The normal sequence is to enable from NVIC outward. (Disable in the opposite direction)
   
   1. attach
   2. enable NVIC
   3. enable device.
   4. 
   
   If this change were to come in it would break async code. Like in the SDMMC driver switching to event wait on D0 for write completion. We want to service the interrupt if it happens before we switch modes. The service should deal with it.
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org