[GitHub] [incubator-openwhisk] rabbah commented on a change in pull request #4316: Update version for Akka dependencies and Scala

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4316: Update version for Akka dependencies and Scala
URL: https://github.com/apache/incubator-openwhisk/pull/4316#discussion_r282338095
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala
 ##########
 @@ -53,9 +53,14 @@ class PoolingRestClient(
 
   //if specified, override the ClientConnection idle-timeout and keepalive socket option value
   private val timeoutSettings = {
-    ConnectionPoolSettings(system.settings.config).withUpdatedConnectionSettings { s =>
-      timeout.map(t => s.withIdleTimeout(t)).getOrElse(s)
-    }
+    val cps = ConnectionPoolSettings(system.settings.config)
+    timeout
+      .map { t =>
+        cps
 
 Review comment:
   this doesn't NPE with the reference to `cps` that's defined on line 56?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services