You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/27 01:01:00 UTC
[GitHub] [doris] stalary opened a new pull request, #11233: [Doc] Fix readme error link
stalary opened a new pull request, #11233:
URL: https://github.com/apache/doris/pull/11233
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Fix readme error link, such as Compilation and Basic Usage
## Checklist(Required)
1. Type of your changes:
- [ ] Improvement
- [ ] Fix
- [ ] Feature-WIP
- [ ] Feature
- [ ] Doc
- [ ] Refator
- [ ] Others:
2. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196155953
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196155934
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196317806
Hi @stalary , the old links are broken due to the suffix `.html`. I think removing the suffix is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196325040
done. @adonis0147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #11233:
URL: https://github.com/apache/doris/pull/11233#discussion_r930663876
##########
README.md:
##########
@@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/
## Compile and install
-See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html)
+See [Compilation](https://doris.apache.org/docs/install/source-install/compilation/)
Review Comment:
```suggestion
See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain)
```
##########
README.md:
##########
@@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/
## Compile and install
-See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html)
+See [Compilation](https://doris.apache.org/docs/install/source-install/compilation/)
## Getting start
-See [Basic Usage](https://doris.apache.org/docs/data-table/basic-usage.html)
+See [Basic Usage](https://doris.apache.org/docs/get-starting/)
Review Comment:
```suggestion
See [Basic Usage](https://doris.apache.org/docs/data-table/basic-usage)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary closed pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
stalary closed pull request #11233: [Doc] Fix readme error link
URL: https://github.com/apache/doris/pull/11233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196323949
> Hi @stalary , the old links are broken due to the suffix `.html`. I think removing the suffix is better.
Ok, I will modify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196393704
Duplicated. See #11091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #11233: [Doc] Fix readme error link
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #11233:
URL: https://github.com/apache/doris/pull/11233#issuecomment-1196405015
> Duplicated. See #11091
Thanks for reminding me, I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org