You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2018/07/23 13:59:25 UTC
[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6392
[FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapshot constructor
## What is the purpose of the change
Fix NPE in CRowSerializerConfigSnapshot constructor
## Verifying this change
This PR adds new test to cover regression.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink f9694
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6392
----
commit cfc62bb5a6728e9cc245e5daf8f2ace721d14f1c
Author: Piotr Nowojski <pi...@...>
Date: 2018-07-23T13:27:03Z
[FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapshot constructor
----
---
[GitHub] flink issue #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapsh...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6392
LGTM, +1
---
[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6392#discussion_r204696678
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java ---
@@ -46,8 +46,6 @@
public CompositeTypeSerializerConfigSnapshot() {}
public CompositeTypeSerializerConfigSnapshot(TypeSerializer<?>... nestedSerializers) {
- Preconditions.checkNotNull(nestedSerializers);
--- End diff --
Ops, scratch that. It wasn't dead code, `CompositeTypeSerializerConfigSnapshot( (TypeSerializer<>[]) null)` would probably trigger this condition. Reverted
---
[GitHub] flink issue #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapsh...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6392
+1, I will close my PR #6231 about this issue
---
[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6392#discussion_r204684670
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java ---
@@ -46,8 +46,6 @@
public CompositeTypeSerializerConfigSnapshot() {}
public CompositeTypeSerializerConfigSnapshot(TypeSerializer<?>... nestedSerializers) {
- Preconditions.checkNotNull(nestedSerializers);
--- End diff --
Not sure about this. It should be perfectly fine that we have a null check here.
---
[GitHub] flink issue #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapsh...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6392
Thanks, merging
---
[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6392
---
[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6392#discussion_r204695915
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java ---
@@ -46,8 +46,6 @@
public CompositeTypeSerializerConfigSnapshot() {}
public CompositeTypeSerializerConfigSnapshot(TypeSerializer<?>... nestedSerializers) {
- Preconditions.checkNotNull(nestedSerializers);
--- End diff --
Wasn't that a dead code? `CompositeTypeSerializerConfigSnapshot(null)` resolves to `CompositeTypeSerializerConfigSnapshot(new TypeSerializer<>{null})`.
---