You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "grobgl (via GitHub)" <gi...@apache.org> on 2023/05/18 15:26:43 UTC
[GitHub] [iceberg] grobgl opened a new pull request, #7645: Python: Add pickle support
grobgl opened a new pull request, #7645:
URL: https://github.com/apache/iceberg/pull/7645
Closes #7644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7645: Python: Add pickle support
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7645:
URL: https://github.com/apache/iceberg/pull/7645#discussion_r1229254092
##########
python/pyiceberg/types.py:
##########
@@ -318,6 +330,9 @@ def __init__(
def __str__(self) -> str:
return f"list<{self.element_type}>"
+ def __getnewargs__(self) -> Tuple[Optional[int], Optional[IcebergType], bool]:
Review Comment:
```suggestion
def __getnewargs__(self) -> Tuple[int, IcebergType, bool]:
```
##########
python/pyiceberg/types.py:
##########
@@ -243,6 +249,9 @@ def __str__(self) -> str:
req = "required" if self.required else "optional"
return f"{self.field_id}: {self.name}: {req} {self.field_type}{doc}"
+ def __getnewargs__(self) -> Tuple[Optional[int], Optional[str], Optional[IcebergType], bool, Optional[str]]:
Review Comment:
```suggestion
def __getnewargs__(self) -> Tuple[int, str, IcebergType, bool, Optional[str]]:
```
##########
python/pyiceberg/types.py:
##########
@@ -363,6 +378,9 @@ def __init__(
def __str__(self) -> str:
return f"map<{self.key_type}, {self.value_type}>"
+ def __getnewargs__(self) -> Tuple[Optional[int], Optional[IcebergType], Optional[int], Optional[IcebergType], bool]:
Review Comment:
```suggestion
def __getnewargs__(self) -> Tuple[int, IcebergType, int, IcebergType, bool]:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] grobgl commented on pull request #7645: Python: Add pickle support
Posted by "grobgl (via GitHub)" <gi...@apache.org>.
grobgl commented on PR #7645:
URL: https://github.com/apache/iceberg/pull/7645#issuecomment-1715352814
Thanks for sorting this out! I was on leave for a while, hoping to get back on it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7645: Python: Add pickle support
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7645:
URL: https://github.com/apache/iceberg/pull/7645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7645: Python: Add pickle support
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7645:
URL: https://github.com/apache/iceberg/pull/7645#issuecomment-1591271715
Thanks for working on this @grobgl. Let me know if I can help in any way with the Dask support!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org