You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/20 06:09:29 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3120: boards/arm/stm32l4: Fix nxstyle warning

xiaoxiang781216 edited a comment on pull request #3120:
URL: https://github.com/apache/incubator-nuttx/pull/3120#issuecomment-803257809


   > PR title is wrong? Says nxstyle fix but changes available channels and init of DFSDM?
   > 
   > Did multiple commits get squashed and keep the wrong commit message?
   > 
   > Thanks
   
   The title is right, the change is for fix the following warning only:
   ```
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:94:58: error: Left bracket not on separate line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:94:60: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:94:62: error: Right bracket not on separate line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:94:7: error: Right brace must be followed by a blank line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:58: error: Left bracket not on separate line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:60: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:62: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:64: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:66: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:68: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:70: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:72: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:74: error: Right bracket not on separate line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:80: error: Long line found
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:110:7: error: Right brace must be followed by a blank line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:126:58: error: Left bracket not on separate line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:126:60: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:126:62: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:126:64: error: Missing whitespace after comma
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:126:66: error: Right bracket not on separate line
   boards/arm/stm32l4/nucleo-l496zg/src/stm32_dfsdm.c:126:7: error: Right brace must be followed by a blank line
   ```
   Yes, the change is little large but it need to fix the warning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org