You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "tarmes@oreka.com" <ta...@oreka.com> on 2004/06/30 09:07:17 UTC

Change Request for WebSVN

Hi All,

This is my 4th attempt at getting this mail onto the dev
list, I don't understand why it isn't getting through.

For those of you who don't know it, WebSVN
(websvn.tigris.org) is a fully featured Web based viewer for
SVN Repositories that been growing steadily in popularity.
It's written in PHP.

Due to the current lack of PHP/Swig bindings, WebSVN uses
the command line to accomplish it's task. The Subversion
developers have thoughtfully actively ensured that output by
the command line client is easy to parse.

Currently WebSVN uses svnlook for most of its work. For
WebSVN 2.0 I want to move away from svnlook and use svn.
This will have several advantages, one of them being the
ability to view remote repositories. The code is 95% working.

In order to complete this latest version, I need to pose two
change requests to the Subversion team. Hopefully there
someone out there who like's WebSVN and would like to see a
newer more powerful version.

1) This is the show stopper at the moment. When calling svn
list directory paths are terminated by a trailing /. This is
good. When calling svn log, they are not. This is bad - not
to mention inconsistant. Would it be possible to make svn
log terminate directory paths with a trailing slash? This
seems particularly important in the XML output mode, since
it's designed to be computer readable. At the moment I can't
tell which paths are directories and which are files. I'm
hoping this would be a small qnd quick fix?

If there are fears that this'll break existing code that
depends upon the XML output, perhaps at the least an
attribute could be added with the file type - dir, bin or
ascii for example. In fact, that would be great, because
I'd know automatically whether or not to display a file or
offer it for download.

2) In order to get the latest log message for a given path,
I have to call svn log -rHEAD:1 URL. This returns all the
logs, even though I'm only interested in the first one. With
a large repository this slows down browsing.

Ideally, I'd be able to call svn log -rCOMMITTED URL to get
only the log for the latest committed revision, however that
doesn't work without a working copy (strange).

I have two solutions to propose:

a) make svn log -rCOMMITTED work without a working copy
b) Offer a --limit X parameter to limit the number of
returned logs to X

I imagine that the --limit command would be generally useful
anyway? It seems limiting to me that I can't type svn log
http://server/svn/proj/tags/1.0 to see the last log entry
for a given tag without having every other log output to the
screen at the same time.

This second problem is annoying because it slows things
down, but it's not a showstopper. If someone could fix the
first problem rapidly I'd be highly appreciative.

Regards,

Tim


////////////////////////////////////////////////////////////
// Webmail Oreka : http://www.oreka.com
////////////////////////////////////////////////////////////



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: Change Request for WebSVN

Posted by Max Bowsher <ma...@ukf.net>.
> "tarmes@oreka.com" <ta...@oreka.com> writes:
>> In order to complete this latest version, I need to pose two
>> change requests to the Subversion team. Hopefully there
>> someone out there who like's WebSVN and would like to see a
>> newer more powerful version.

kfogel@collab.net wrote:
> Do you have time/inclination to implement patches for any of these?

And, if you do not, filing them in the issue tracker is a good way to stop them being forgotten about.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Change Request for WebSVN

Posted by kf...@collab.net.
"tarmes@oreka.com" <ta...@oreka.com> writes:
> This is my 4th attempt at getting this mail onto the dev
> list, I don't understand why it isn't getting through.

The list is moderated for first-time posters.  I don't recall ever
seeing this message before I moderated it through today, but who
knows...

> Due to the current lack of PHP/Swig bindings, WebSVN uses
> the command line to accomplish it's task. The Subversion
> developers have thoughtfully actively ensured that output by
> the command line client is easy to parse.

/me grins :-)

> Currently WebSVN uses svnlook for most of its work. For
> WebSVN 2.0 I want to move away from svnlook and use svn.
> This will have several advantages, one of them being the
> ability to view remote repositories. The code is 95% working.
> 
> In order to complete this latest version, I need to pose two
> change requests to the Subversion team. Hopefully there
> someone out there who like's WebSVN and would like to see a
> newer more powerful version.
> 
> 1) This is the show stopper at the moment. When calling svn
> list directory paths are terminated by a trailing /. This is
> good. When calling svn log, they are not. This is bad - not
> to mention inconsistant. Would it be possible to make svn
> log terminate directory paths with a trailing slash? This
> seems particularly important in the XML output mode, since
> it's designed to be computer readable. At the moment I can't
> tell which paths are directories and which are files. I'm
> hoping this would be a small qnd quick fix?

Ooooh.

I don't know how hard this would be to change; but also, we're loathe
to change *any* output formats before 2.0.  However, for XML it should
be possible...

> If there are fears that this'll break existing code that
> depends upon the XML output, perhaps at the least an
> attribute could be added with the file type - dir, bin or
> ascii for example. In fact, that would be great, because
> I'd know automatically whether or not to display a file or
> offer it for download.

... as you describe above, with a new attribute.

Do you have time to implement a patch for this?  (That's a neutral
question -- it's fine to say you don't, I'm just shamelessly trying to
get another developer on board.)

> 2) In order to get the latest log message for a given path,
> I have to call svn log -rHEAD:1 URL. This returns all the
> logs, even though I'm only interested in the first one. With
> a large repository this slows 
> d be able to call svn log -rCOMMITTED URL to get
> only the log for the latest committed revision, however that
> doesn't work without a working copy (strange).

This we can add any time, of course, no compatibility problems.

> I have two solutions to propose:
> 
> a) make svn log -rCOMMITTED work without a working copy
> b) Offer a --limit X parameter to limit the number of
> returned logs to X
>
> I imagine that the --limit command would be generally useful
> anyway? It seems limiting to me that I can't type svn log
> http://server/svn/proj/tags/1.0 to see the last log entry
> for a given tag without having every other log output to the
> screen at the same time.

I think it's more important to do (a) first, since we already have the
COMMITTED keyword anyway.

Do you have time/inclination to implement patches for any of these?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org