You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/09 02:46:00 UTC
[GitHub] [hbase] tedyu commented on a change in pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.
tedyu commented on a change in pull request #1635:
URL: https://github.com/apache/hbase/pull/1635#discussion_r467527897
##########
File path: hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/master/TestMetricsMasterProcSourceImpl.java
##########
@@ -48,4 +69,11 @@ public void testGetInstance() throws Exception {
CompatibilitySingletonFactory.getInstance(MetricsMasterProcSourceFactory.class));
}
+ @Test
+ public void testSplitProcedureMetrics() {
+ HELPER.assertGauge(MetricsMasterProcSource.NUM_SPLIT_PROCEDURE_REQUEST_NAME, 32, masterProcSource);
+ HELPER.assertGauge(MetricsMasterProcSource.NUM_SPLIT_PROCEDURE_SUCCESS_NAME, 24, masterProcSource);
+ HELPER.assertGauge("SplitProcedureTime_max", 2082, masterProcSource);
Review comment:
Can you change the test so that max > min ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org