[jira] Updated: (JDO-348) Fostore20 doesn't compile with latest changes to api20

["Martin Zaun (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/JDO-348?page=all ]

Martin Zaun updated JDO-348:
----------------------------

    Attachment: FOStorePM.newMakeTransient.patch

Looking for a quick fix for this compilation issue, I've attached a patch.

My thoughts:
- The implementation of the new methods
    public void makeTransient(Object pc, boolean useFetchPlan) 
    public void makeTransientAll(Object[] pcs, boolean useFetchPlan) 
    public void makeTransientAll(Collection pcs, boolean useFetchPlan)
  needs to go into either of
    org.apache.jdo.impl.pm.PersistenceManagerImpl
    org.apache.jdo.impl.fostore.FOStorePM.
  Since PersistenceManagerImpl cannot implement this method generically, I felt that the implementation
  should be in the backend-specific classes, i.e., FOStorePM.

- Because FOStorePM doesn't support the concept of a fetch plan, the methods could either throw an
  UnsupportedOperationException or ignore the 'useFetchPlan' argument.  Not throwing an exception
  seems best to be, since the API/spec doesn't indicate those methods as being optional and the
  semantics of ignoring the 'useFetchPlan' argument seems consistent to me if there's no fetch plan.


> Fostore20 doesn't compile with latest changes to api20
> ------------------------------------------------------
>
>          Key: JDO-348
>          URL: http://issues.apache.org/jira/browse/JDO-348
>      Project: JDO
>         Type: Bug
>   Components: runtime20
>     Versions: JDO 2 rc1
>     Reporter: Craig Russell
>     Assignee: Martin Zaun
>  Attachments: FOStorePM.newMakeTransient.patch
>
> java:compile:
>     [echo] Compiling to g:\olsen\jdo\apache_clean\jdo\trunk\fostore20/target/cla
> sses
>     [javac] Compiling 100 source files to G:\olsen\jdo\apache_clean\jdo\trunk\fo
> store20\target\classes
> G:\olsen\jdo\apache_clean\jdo\trunk\fostore20\src\java\org\apache\jdo\impl\fosto
> re\FOStorePM.java:35: org.apache.jdo.impl.fostore.FOStorePM is not abstract and
> does not override abstract method makeTransientAll(java.util.Collection,boolean)
>  in javax.jdo.PersistenceManager
> public class FOStorePM extends PersistenceManagerImpl
>        ^
> Note: G:\olsen\jdo\apache_clean\jdo\trunk\fostore20\src\java\org\apache\jdo\impl
> \fostore\FOStoreInput.java uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> 1 error
> BUILD FAILED

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira