[GitHub] [airflow] potiuk commented on pull request #33746: Refactor: remove unused state - SHUTDOWN

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #33746:
URL: https://github.com/apache/airflow/pull/33746#issuecomment-1694488463

   Are you sure there are no users that have a "shutdo wn" state in their DB and would like to see that task displayed in the UI ? Airflow users have also historical database with historical tasks status.
   
   My question is here - did you consider the case that somene has such task in the database? what will happen there?
   
   I am not saying it is wrong to remove it, I am just asking if you considered it and and thought about the historical data affecting the current code.
   
   * What will happen if someone has historical entries with this state?
   * Is it likely to happen? (maybe not - in which case above question does not matter, but it depends on the answer to that question.
   * Wil there be a graceful fallback in  case it happens?
   
   I think answer to those questions is important when you decide to remove something. It is easy to say "I remove something because it is not used". But in case "it was used" - you need to have analysed what impact it has.
   
   Can you please answer the above questions @Bisk1 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org