You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/18 02:05:36 UTC
Review Request 17082: Fixed display of table filter for empty tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Fixed display of table filter for empty tables
Diffs
-----
src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd
Diff: https://reviews.apache.org/r/17082/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17082: Fixed display of table filter for empty tables
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review42707
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Jan. 18, 2014, 1:05 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17082/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 1:05 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed display of table filter for empty tables
>
>
> Diffs
> -----
>
> src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd
>
> Diff: https://reviews.apache.org/r/17082/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17082: Fixed display of table filter for empty
tables
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56551
-----------------------------------------------------------
Patch looks great!
Reviews applied: [17082]
All tests passed.
- Mesos ReviewBot
On Jan. 18, 2014, 1:05 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17082/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 1:05 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed display of table filter for empty tables
>
>
> Diffs
> -----
>
> src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd
>
> Diff: https://reviews.apache.org/r/17082/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17082: Fixed display of table filter for empty
tables
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Oct. 14, 2014, 9:38 a.m., Tobi Knaup wrote:
> > Ship It!
Awesome - will land this today.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56538
-----------------------------------------------------------
On Jan. 17, 2014, 5:05 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17082/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 5:05 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed display of table filter for empty tables
>
>
> Diffs
> -----
>
> src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd
>
> Diff: https://reviews.apache.org/r/17082/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17082: Fixed display of table filter for empty
tables
Posted by Tobi Knaup <to...@knaup.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56538
-----------------------------------------------------------
Ship it!
Ship It!
- Tobi Knaup
On Jan. 18, 2014, 1:05 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17082/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 1:05 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed display of table filter for empty tables
>
>
> Diffs
> -----
>
> src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd
>
> Diff: https://reviews.apache.org/r/17082/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17082: Fixed display of table filter for empty tables
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/
-----------------------------------------------------------
(Updated Jan. 18, 2014, 1:05 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Fixed display of table filter for empty tables
Diffs
-----
src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd
Diff: https://reviews.apache.org/r/17082/diff/
Testing
-------
Thanks,
Thomas Rampelberg