You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "balloon72 (via GitHub)" <gi...@apache.org> on 2023/02/08 15:35:37 UTC
[GitHub] [shenyu] balloon72 opened a new pull request, #4367: Fix 4354 Optimize code for shenyu-admin
balloon72 opened a new pull request, #4367:
URL: https://github.com/apache/shenyu/pull/4367
Optimize code for shenyu-admin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4367: Fix 4354 Optimize code for shenyu-admin
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4367:
URL: https://github.com/apache/shenyu/pull/4367#issuecomment-1423497976
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4367](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29c91ed) into [master](https://codecov.io/gh/apache/shenyu/commit/9725874eaa20ec87a3d8beea168f3a9ade9ba76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9725874) will **increase** coverage by `0.04%`.
> The diff coverage is `46.15%`.
```diff
@@ Coverage Diff @@
## master #4367 +/- ##
============================================
+ Coverage 68.31% 68.36% +0.04%
+ Complexity 7505 7504 -1
============================================
Files 1020 1020
Lines 28793 28774 -19
Branches 2566 2566
============================================
- Hits 19671 19670 -1
+ Misses 7588 7570 -18
Partials 1534 1534
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...disruptor/subscriber/ApiDocExecutorSubscriber.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL3N1YnNjcmliZXIvQXBpRG9jRXhlY3V0b3JTdWJzY3JpYmVyLmphdmE=) | `27.27% <0.00%> (+4.19%)` | :arrow_up: |
| [.../apache/shenyu/admin/listener/etcd/EtcdClient.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbGlzdGVuZXIvZXRjZC9FdGNkQ2xpZW50LmphdmE=) | `59.25% <0.00%> (ø)` | |
| [...va/org/apache/shenyu/admin/model/bean/DocInfo.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvYmVhbi9Eb2NJbmZvLmphdmE=) | `90.00% <ø> (ø)` | |
| [...ache/shenyu/admin/model/dto/CreateResourceDTO.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0NyZWF0ZVJlc291cmNlRFRPLmphdmE=) | `100.00% <ø> (+26.92%)` | :arrow_up: |
| [...che/shenyu/admin/model/entity/DashboardUserDO.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZW50aXR5L0Rhc2hib2FyZFVzZXJETy5qYXZh) | `67.41% <0.00%> (+0.74%)` | :arrow_up: |
| [.../shenyu/admin/service/impl/AppAuthServiceImpl.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0FwcEF1dGhTZXJ2aWNlSW1wbC5qYXZh) | `77.45% <0.00%> (ø)` | |
| [.../java/org/apache/shenyu/admin/utils/HttpUtils.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvSHR0cFV0aWxzLmphdmE=) | `10.16% <0.00%> (ø)` | |
| [...a/org/apache/shenyu/admin/model/vo/RoleEditVO.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvdm8vUm9sZUVkaXRWTy5qYXZh) | `20.00% <50.00%> (-0.59%)` | :arrow_down: |
| [.../service/manager/impl/LoadServiceDocEntryImpl.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9tYW5hZ2VyL2ltcGwvTG9hZFNlcnZpY2VEb2NFbnRyeUltcGwuamF2YQ==) | `23.00% <50.00%> (ø)` | |
| [...ache/shenyu/admin/aspect/DataPermissionAspect.java](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vYXNwZWN0L0RhdGFQZXJtaXNzaW9uQXNwZWN0LmphdmE=) | `95.00% <100.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/shenyu/pull/4367?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4367: Fix 4354 Optimize code for shenyu-admin
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 merged PR #4367:
URL: https://github.com/apache/shenyu/pull/4367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org