You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/20 17:59:46 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #1135: MINIFICPP-1609 Handle bash in the same way as patch
fgerlits opened a new pull request #1135:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1135
When building Minifi with Azure on Windows, `cmake/BundledAzureSdkCpp.cmake` assumed that `bash` was on the PATH. My local Git for Windows installation includes `bash.exe`, but it is not on the PATH. Also, my Windows machine contains a `bash.exe` in `C:\Windows\System32`, which does not work the same way as Git Bash, so that had to be excluded.
https://issues.apache.org/jira/browse/MINIFICPP-1609
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #1135: MINIFICPP-1609 Handle bash in the same way as patch
Posted by GitBox <gi...@apache.org>.
fgerlits commented on pull request #1135:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1135#issuecomment-883960151
Yes, a CMake function would be better. If you have something in mind, then go for it, but I don't know how much time we want to spend on this, as the current approach (is ugly but) works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1135: MINIFICPP-1609 Handle bash in the same way as patch
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #1135:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1135#issuecomment-884017376
I was not able to escape a cmd.exe command in cmake and have it properly end up in the generated VS solution, so let's keep the current version. `"`s mysteriously disappear or get escaped to `\"`, depending on the position, while `\"` ends up on the command line verbatim, so I gave up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1135: MINIFICPP-1609 Handle bash in the same way as patch
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1135:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org