You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:29:53 UTC
Review Request 66157: Fixed header inclusions for `csi/spec.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66157/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
Fixed header inclusions for `csi/spec.hpp`.
Diffs
-----
src/csi/utils.hpp 2dd61bc500de1f97a3fb39c0571b5d3fdb4f7989
src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
Diff: https://reviews.apache.org/r/66157/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66157: Fixed header inclusions for `csi/spec.hpp`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66157/#review199544
-----------------------------------------------------------
Fix it, then Ship it!
src/csi/utils.hpp
Lines 23-24 (patched)
<https://reviews.apache.org/r/66157/#comment279833>
While the order of inclusion in this patch is consistent, other instances of this header being included are not. I think it should be included there like in this patch (alphabethical after C and C++ headers).
Could you have a look at instances of
#include <csi/spec.hpp>
and fix them?
- Benjamin Bannier
On March 20, 2018, 12:29 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66157/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 12:29 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed header inclusions for `csi/spec.hpp`.
>
>
> Diffs
> -----
>
> src/csi/utils.hpp 2dd61bc500de1f97a3fb39c0571b5d3fdb4f7989
> src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
> src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
>
>
> Diff: https://reviews.apache.org/r/66157/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66157: Fixed header inclusions for `csi/spec.hpp`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66157/
-----------------------------------------------------------
(Updated March 20, 2018, 10:43 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Addressed Benjamin's comments and fixed all other inclusions of `<csi/spec.hpp>`.
Repository: mesos
Description
-------
Fixed header inclusions for `csi/spec.hpp`.
Diffs (updated)
-----
src/csi/client.hpp 0ff97eea9f27bff0ce79acb5a212aaa7a4098a55
src/csi/utils.hpp 2dd61bc500de1f97a3fb39c0571b5d3fdb4f7989
src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
src/resource_provider/storage/disk_profile.cpp ba195cb0fa89f95135a20d25c98e5825f057c75e
src/resource_provider/storage/uri_disk_profile.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf
src/resource_provider/storage/uri_disk_profile.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf
src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
Diff: https://reviews.apache.org/r/66157/diff/2/
Changes: https://reviews.apache.org/r/66157/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao