You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by "Lukasz Lenart (JIRA)" <ji...@apache.org> on 2011/02/17 19:40:24 UTC

[jira] Reopened: (WW-3461) Don't hold locks as long when creating validators in AnnotationActionValidatorManager

     [ https://issues.apache.org/jira/browse/WW-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart reopened WW-3461:
-------------------------------


> Don't hold locks as long when creating validators in AnnotationActionValidatorManager
> -------------------------------------------------------------------------------------
>
>                 Key: WW-3461
>                 URL: https://issues.apache.org/jira/browse/WW-3461
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.6
>            Reporter: Leigh Anderson
>            Assignee: Lukasz Lenart
>             Fix For: 2.2.2
>
>         Attachments: validatormanager.patch
>
>
> Under load, the lock held in AnnotationActionValidatorManager.getValidators on validatorCache becomes contended. This lock is currently held while all the validators are created. The attached patch reduces the scope of the lock to just doing the cache lookup + taking a defensive copy of the list of validators for that key.  This improved throughput and latency in our tests.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira