You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "UtkershBasnet (via GitHub)" <gi...@apache.org> on 2026/03/12 14:50:13 UTC
[PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
UtkershBasnet opened a new pull request, #63451:
URL: https://github.com/apache/airflow/pull/63451
All refactorings applied. Here's a summary:
DagCalendarTab.ts — 6 changes:
4× .waitFor({ state: "visible" }) → await expect(...).toBeVisible() (web-first assertions)
1× Manual isVisible() + conditional waitFor("hidden") → await expect(...).toBeHidden() ,this also simplifies the logic since toBeHidden() passes immediately if the overlay was never present
1× waitForFunction() with document.querySelectorAll() → await expect(this.calendarCells.first()).toBeVisible() (locator-based waiting)
dag-calendar-tab.spec.ts — 1 change:
const count = await ...; expect(count).toBeGreaterThan(0) → await expect(calendar.activeCells).not.toHaveCount(0) (web-first assertion)
* closes: #63409
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes (please specify the tool below)
Generated-by: Claude Code following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #63451:
URL: https://github.com/apache/airflow/pull/63451#issuecomment-4195005247
@UtkershBasnet This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :warning: **Unresolved review comments**: This PR has 1 unresolved review thread from maintainers: **@choo121600** (MEMBER): 1 unresolved thread. Please review and resolve all inline review comments before requesting another review. You can resolve a conversation by clicking 'Resolve conversation' on each thread after addressing the feedback. See [pull request guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
> **Note:** Your branch is **322 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.
**What to do next:**
- The comment informs you what you need to do.
- Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
- There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
- Maintainers will then proceed with a normal review.
There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
Posted by "UtkershBasnet (via GitHub)" <gi...@apache.org>.
UtkershBasnet commented on PR #63451:
URL: https://github.com/apache/airflow/pull/63451#issuecomment-4053271732
Sorry I initially opened the PR from a branch (dag-calendar) that was based on an outdated state of my fork's main. Because my fork was not synced with upstream.
Can you pls re-run the CI and check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #63451:
URL: https://github.com/apache/airflow/pull/63451#discussion_r2968930936
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
Review Comment:
This test seems to be flaky. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #63451:
URL: https://github.com/apache/airflow/pull/63451#issuecomment-4047369420
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #63451:
URL: https://github.com/apache/airflow/pull/63451#issuecomment-4249390975
@UtkershBasnet
Thanks for your contribution!
Since this was merged first in #64189, so I’m going to close this PR.
Looking forward to your future contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 closed pull request #63451: fix:Improve Playwright test patterns in dag-calendar-tab.spec.ts
URL: https://github.com/apache/airflow/pull/63451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org