You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/12/17 09:56:43 UTC
Review Request 69572: Validated that resource providers use correct
ID in operation states.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69572/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Bugs: MESOS-9479
https://issues.apache.org/jira/browse/MESOS-9479
Repository: mesos
Description
-------
We expect resource providers to set their IDs in operation status messages.
This patch adds some assertion that the IDs match our expectations, and
adjusts some test code to honor these assumptions.
Diffs
-----
src/resource_provider/manager.cpp 103f5458ec882a37357265bd680a59da0bbad6b3
src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa
src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe
Diff: https://reviews.apache.org/r/69572/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69572: Validated that resource providers use
correct ID in operation states.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69572/#review211398
-----------------------------------------------------------
PASS: Mesos patch 69572 was successfully built and tested.
Reviews applied: `['69569', '69572']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2721/mesos-review-69572
- Mesos Reviewbot Windows
On Dec. 17, 2018, 9:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69572/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 9:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9479
> https://issues.apache.org/jira/browse/MESOS-9479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We expect resource providers to set their IDs in operation status
> messages. This patch adds some assertion that the IDs match our
> expectations, and adjusts some test code to honor these assumptions.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 103f5458ec882a37357265bd680a59da0bbad6b3
> src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa
> src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe
>
>
> Diff: https://reviews.apache.org/r/69572/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69572: Validated that resource providers use
correct ID in operation states.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Dec. 17, 2018, 11:33 p.m., Chun-Hung Hsiao wrote:
> > src/tests/master_slave_reconciliation_tests.cpp
> > Lines 501 (patched)
> > <https://reviews.apache.org/r/69572/diff/1/?file=2114346#file2114346line501>
> >
> > Not sure if this is gramatically correct.
> > Should it be (The resource provider is/has been) "Asked to reconcile before subscription finishes"?
> >
> > I'm not a native speaker so please excuse me if I'm wrong ;)
I wanted to emphasize the temporal ordering (subscription -> reconciliation). I'll leave this as is, dropping.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69572/#review211372
-----------------------------------------------------------
On Dec. 17, 2018, 10:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69572/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 10:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9479
> https://issues.apache.org/jira/browse/MESOS-9479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We expect resource providers to set their IDs in operation status messages.
> This patch adds some assertion that the IDs match our expectations, and
> adjusts some test code to honor these assumptions.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 103f5458ec882a37357265bd680a59da0bbad6b3
> src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa
> src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe
>
>
> Diff: https://reviews.apache.org/r/69572/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69572: Validated that resource providers use
correct ID in operation states.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69572/#review211372
-----------------------------------------------------------
src/tests/master_slave_reconciliation_tests.cpp
Lines 501 (patched)
<https://reviews.apache.org/r/69572/#comment296378>
Not sure if this is gramatically correct.
Should it be (The resource provider is/has been) "Asked to reconcile before subscription finishes"?
I'm not a native speaker so please excuse me if I'm wrong ;)
- Chun-Hung Hsiao
On Dec. 17, 2018, 9:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69572/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 9:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9479
> https://issues.apache.org/jira/browse/MESOS-9479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We expect resource providers to set their IDs in operation status messages.
> This patch adds some assertion that the IDs match our expectations, and
> adjusts some test code to honor these assumptions.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 103f5458ec882a37357265bd680a59da0bbad6b3
> src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa
> src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe
>
>
> Diff: https://reviews.apache.org/r/69572/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69572: Validated that resource providers use
correct ID in operation states.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69572/#review211354
-----------------------------------------------------------
PASS: Mesos patch 69572 was successfully built and tested.
Reviews applied: `['69569', '69572']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2712/mesos-review-69572
- Mesos Reviewbot Windows
On Dec. 17, 2018, 9:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69572/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 9:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9479
> https://issues.apache.org/jira/browse/MESOS-9479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We expect resource providers to set their IDs in operation status messages.
> This patch adds some assertion that the IDs match our expectations, and
> adjusts some test code to honor these assumptions.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 103f5458ec882a37357265bd680a59da0bbad6b3
> src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa
> src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe
>
>
> Diff: https://reviews.apache.org/r/69572/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69572: Validated that resource providers use
correct ID in operation states.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69572/#review211371
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Dec. 17, 2018, 9:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69572/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 9:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9479
> https://issues.apache.org/jira/browse/MESOS-9479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We expect resource providers to set their IDs in operation status messages.
> This patch adds some assertion that the IDs match our expectations, and
> adjusts some test code to honor these assumptions.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 103f5458ec882a37357265bd680a59da0bbad6b3
> src/tests/master_slave_reconciliation_tests.cpp de6e382ed16d8c02d90dd6157ded1aaae9b593aa
> src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe
>
>
> Diff: https://reviews.apache.org/r/69572/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>