[jira] [Commented] (XERCESJ-1692) Inconsistent method name

["Michael Glavassevich (JIRA)" <xe...@xml.apache.org>]

    [ https://issues.apache.org/jira/browse/XERCESJ-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461189#comment-16461189 ] 

Michael Glavassevich commented on XERCESJ-1692:
-----------------------------------------------

Changing the name of a public method is an incompatible change. Any users of the method would be broken so there's also a technical reason why this can't be done now.

> Inconsistent method name
> ------------------------
>
>                 Key: XERCESJ-1692
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1692
>             Project: Xerces2-J
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named as "getIndenting", but the method checks whether the indentation is specified or not.
> So renaming the method as "isIndenting" should be more clear than "getIndenting".
> {code:java}
>    /**
>       * Returns true if indentation was specified.
>       */
>       public boolean getIndenting()
>      {
>          return ( _indent > 0 );
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org