You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Zack Brown <zb...@tumblerings.org> on 2002/11/03 14:32:41 UTC

Bug? 'svn log' doesn't follow file-moves

Hi,

When I do an 'svn log COMMITTERS', I notice that the very bottom entry
shows COMMITTERS being renamed from AUTHORS.

Is that a bug? I'd expect the log subcommand to follow file-moves.

Be well,
Zack

-- 
Zack Brown

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug? 'svn log' doesn't follow file-moves

Posted by Greg Stein <gs...@lyra.org>.
On Sun, Nov 03, 2002 at 04:00:09PM -0600, cmpilato@collab.net wrote:
> Zack Brown <zb...@tumblerings.org> writes:
> > > `svn log` (without --strict) does follow file moves.  However:
> > > 
> > >    rev 347:  kfogel | 2001-10-29 16:20:47 -0600 (Mon, 29 Oct 2001) | 5 lines
> > >    Changed paths:
> > >       D /trunk/AUTHORS
> > >       A /trunk/COMMITTERS
> > > 
> > > the absence of "(copied from ...)" on the COMMITTERS line above means
> > > that the filesystem didn't log this operation as a true copy -- just
> > > as an add and a delete.
> > 
> > Is that possibly because the tree was patched by one of Subversion's unified
> > diffs instead of a direct commit? 
> 
> Possibly.  Though, in this case, I think it was because we hadn't yet
> implemented the 'move' command. :-)

Yup. We didn't get the move command until November or December, as I recall.

Until that point, everything was delete-then-add. We also avoided as much of
that as possible, waiting for when we had true copies and moves.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug? 'svn log' doesn't follow file-moves

Posted by cm...@collab.net.
Zack Brown <zb...@tumblerings.org> writes:

> > `svn log` (without --strict) does follow file moves.  However:
> > 
> >    rev 347:  kfogel | 2001-10-29 16:20:47 -0600 (Mon, 29 Oct 2001) | 5 lines
> >    Changed paths:
> >       D /trunk/AUTHORS
> >       A /trunk/COMMITTERS
> > 
> > the absence of "(copied from ...)" on the COMMITTERS line above means
> > that the filesystem didn't log this operation as a true copy -- just
> > as an add and a delete.
> 
> Is that possibly because the tree was patched by one of Subversion's unified
> diffs instead of a direct commit? 

Possibly.  Though, in this case, I think it was because we hadn't yet
implemented the 'move' command. :-)

> i.e. is there any way for someone without direct commit access to a
> tree, to submit a patch to properly rename a file?

Without a more robust patch format, no, this is not possible.  

Our 'svn diff' output gets us per-file change support (like GNU diff
itself does).  And while 'svn diff' also dumps out property mods in a
clumsy way, a) 'patch' sees that output as rubbish, and b) there is no
'svn patch' yet which would interpret that data as more than rubbish.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug? 'svn log' doesn't follow file-moves

Posted by Zack Brown <zb...@tumblerings.org>.
On Sun, Nov 03, 2002 at 08:39:45AM -0600, cmpilato@collab.net wrote:
> Zack Brown <zb...@tumblerings.org> writes:
> 
> > Hi,
> > 
> > When I do an 'svn log COMMITTERS', I notice that the very bottom entry
> > shows COMMITTERS being renamed from AUTHORS.
> > 
> > Is that a bug? I'd expect the log subcommand to follow file-moves.
> 
> `svn log` (without --strict) does follow file moves.  However:
> 
>    rev 347:  kfogel | 2001-10-29 16:20:47 -0600 (Mon, 29 Oct 2001) | 5 lines
>    Changed paths:
>       D /trunk/AUTHORS
>       A /trunk/COMMITTERS
> 
> the absence of "(copied from ...)" on the COMMITTERS line above means
> that the filesystem didn't log this operation as a true copy -- just
> as an add and a delete.

Is that possibly because the tree was patched by one of Subversion's unified
diffs instead of a direct commit? i.e. is there any way for someone without
direct commit access to a tree, to submit a patch to properly rename a file?

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
> 

-- 
Zack Brown

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug? 'svn log' doesn't follow file-moves

Posted by cm...@collab.net.
Zack Brown <zb...@tumblerings.org> writes:

> Hi,
> 
> When I do an 'svn log COMMITTERS', I notice that the very bottom entry
> shows COMMITTERS being renamed from AUTHORS.
> 
> Is that a bug? I'd expect the log subcommand to follow file-moves.

`svn log` (without --strict) does follow file moves.  However:

   rev 347:  kfogel | 2001-10-29 16:20:47 -0600 (Mon, 29 Oct 2001) | 5 lines
   Changed paths:
      D /trunk/AUTHORS
      A /trunk/COMMITTERS

the absence of "(copied from ...)" on the COMMITTERS line above means
that the filesystem didn't log this operation as a true copy -- just
as an add and a delete.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org